[ 
https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728679#comment-17728679
 ] 

ASF GitHub Bot commented on HADOOP-18752:
-----------------------------------------

dannycjones commented on code in PR #5689:
URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214206939


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md:
##########
@@ -12,35 +12,40 @@
   limitations under the License. See accompanying LICENSE file.
 -->
 
-# Experimental: Controlling the S3A Directory Marker Behavior
+# Controlling the S3A Directory Marker Behavior
 
-This document discusses an experimental feature of the S3A
-connector since Hadoop 3.3.1: the ability to retain directory
-marker objects above paths containing files or subdirectories.
+This document discusses an performance feature of the S3A
+connector: directory markers are not deleted unless the
+client is explicitly configured to do so.

Review Comment:
   if this PR gets updated, small, typo to fix
   
   ```suggestion
   This document discusses a performance feature of the S3A
   connector: directory markers are not deleted unless the
   client is explicitly configured to do so.
   ```





> Change fs.s3a.directory.marker.retention to "keep"
> --------------------------------------------------
>
>                 Key: HADOOP-18752
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18752
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.5
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> Change the default value of "fs.s3a.directory.marker.retention" to keep; 
> update docs to match.
> maybe include with HADOOP-17802 so we don't blow up with fewer markers being 
> created.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to