dannycjones commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1214208594
########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ########## @@ -161,7 +176,7 @@ When a file is created under a path, the directory marker is deleted. And when a file is deleted, if it was the last file in the directory, the marker is recreated. -And, historically, When a path is listed, if a marker to that path is found, *it +And, historically, when a path is listed, if a marker to that path is found, *it has been interpreted as an empty directory.* Review Comment: (This isn't added in this PR but...) is this really true? I tried an integ test using `listFiles` on the Hadoop 3.0 code base. It seemed happy. Is it worth being specific with what will or won't make this assumption? ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ########## @@ -237,29 +252,19 @@ of backwards compatibility. There is now an option `fs.s3a.directory.marker.retention` which controls how markers are managed when new files are created -*Default* `delete`: a request is issued to delete any parental directory markers +1.`delete`: a request is issued to delete any parental directory markers Review Comment: markdown won't like this ```suggestion 1. `delete`: a request is issued to delete any parental directory markers ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
