9uapaw commented on code in PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#discussion_r1216949143
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationLimits.java:
##########
@@ -194,6 +207,8 @@ public void testAMResourceLimit() throws Exception {
Resource clusterResource = Resource.newInstance(80 * GB, 40);
root.updateClusterResource(clusterResource, new ResourceLimits(
clusterResource));
+ LeafQueue queue = (LeafQueue) root.getChildQueues().stream().filter(
+ child ->
child.getQueueName().equals(A)).findFirst().orElseThrow(NoSuchElementException::new);
Review Comment:
Its been a while since I made these changes, but as I remember this
phenomenon was repeated multiple times in several tests and caused a lot of
headaches. Essentially, the original LeafQueue which was spied upon is not part
of the queue hierarchy, but instantiated separately in this test file only,
therefore it will not be a part of the calculation steps either. IMO we should
never initialize queues like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
