anujmodi2021 commented on code in PR #5711:
URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217753671


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:
##########
@@ -347,7 +347,7 @@ private boolean executeHttpOperation(final int retryCount,
 
     LOG.debug("HttpRequest: {}: {}", operationType, httpOperation);
 
-    if (client.getRetryPolicy().shouldRetry(retryCount, 
httpOperation.getStatusCode())) {
+    if (client.getRetryPolicy(failureReason).shouldRetry(retryCount, 
httpOperation.getStatusCode())) {

Review Comment:
   If iteration0 fails then line number 350 should not hit. Failure will be 
caught by one of the exceptions and inside catch failureReason will be CT. 
Inside catch itself shouldRetry() will be called for LinearRetry and it will 
return false here itself.
   
   I think I am missing something here. Please correct me if I am wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to