virajjasani commented on code in PR #5723:
URL: https://github.com/apache/hadoop/pull/5723#discussion_r1226918098
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java:
##########
@@ -400,10 +403,8 @@ public <T extends BaseRecord> StateStoreOperationResult
putAll(
toWrite.put(recordPath, record);
} else if (errorIfExists) {
LOG.error("Attempt to insert record {} that already exists",
recordPath);
- if (metrics != null) {
- metrics.addFailure(monotonicNow() - start);
Review Comment:
without this patch, it used to make sense keeping metric update logic here,
because we were returning directly from here. but now we don't need this
because metric update is going to take place at the end anyways (just like
other cases).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
