brumi1024 commented on PR #5736: URL: https://github.com/apache/hadoop/pull/5736#issuecomment-1591114150
Thanks @tomicooler for the update, looks good to me, and improves the readability. It's not strictly related to this patch, and probably not in its scope, but I don't really get why are we doing the following flow for a simple JSON pretty print: string -> JSON POJO (lib#1) -> string -> create an ObjectMapper per pretty print (it's a really heavyweight object, it should be reused) -> JSON POJO (lib#2) -> string again. This is much-much slower than necessary. Probably this should be refactored later. Regardless I'll merge this now, and create a followup ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
