hfutatzhanghb commented on code in PR #5753:
URL: https://github.com/apache/hadoop/pull/5753#discussion_r1235075644
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoStriped.java:
##########
@@ -128,8 +128,25 @@ boolean addStorage(DatanodeStorageInfo storage, Block
reportedBlock) {
DatanodeStorageInfo old = getStorageInfo(index);
if (old != null && !old.equals(storage)) { // over replicated
// check if the storage has been stored
+ boolean blockIdNotEquals = false;
+ long blockGroupId =
BlockIdManager.convertToStripedID(reportedBlock.getBlockId() - blockIndex);
+ Iterator<BlockInfo> blockIterator = old.getBlockIterator();
+ while (blockIterator.hasNext()) {
+ BlockInfo blockInfo = blockIterator.next();
+ if (!blockInfo.isStriped()) {
+ continue;
+ } else {
+ if (BlockIdManager.convertToStripedID(blockInfo.getBlockId()) ==
blockGroupId) {
+ Block blockOnOldStorage = ((BlockInfoStriped)
blockInfo).getBlockOnStorage(old);
+ if (blockOnOldStorage.getBlockId() != reportedBlock.getBlockId()) {
+ blockIdNotEquals = true;
Review Comment:
@zhangshuyan0 Thanks shuyan for your reviewing, this PR still has some
problems, I will fix it soonly and push it. I think it is efficent for us to
disscuss after then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
