[
https://issues.apache.org/jira/browse/HADOOP-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736118#comment-17736118
]
ASF GitHub Bot commented on HADOOP-18778:
-----------------------------------------
dannycjones commented on code in PR #5763:
URL: https://github.com/apache/hadoop/pull/5763#discussion_r1238487030
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java:
##########
@@ -448,7 +448,7 @@ public void testReadOnlyOperations() throws Throwable {
policy(
statement(false, S3_ALL_BUCKETS, S3_PATH_WRITE_OPERATIONS),
STATEMENT_ALL_S3,
- STATEMENT_ALLOW_SSE_KMS_READ));
+ STATEMENT_ALLOW_SSE_KMS_RW));
Review Comment:
Why does this need changing? It's for Server Side Encryption. (Was it always
broken?)
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java:
##########
@@ -118,6 +118,7 @@ private static int calculateNumBlocks(long largeFileSize,
int blockSize) {
@Test
public void testReadLargeFileFully() throws Throwable {
describe("read a large file fully, uses S3ACachingInputStream");
+ skipIfClientSideEncryption();
Review Comment:
Shall we just move these into `openFS()` since we're assuming the FS it
provides is not compatible with CSE for now?
> Test failures with CSE enabled
> ------------------------------
>
> Key: HADOOP-18778
> URL: https://issues.apache.org/jira/browse/HADOOP-18778
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Ahmar Suhail
> Assignee: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.9
>
>
> The following tests fail when run hadoop-aws suite is run with CSE enabled:
>
> {{ITestS3APrefetchingInputStream.testRandomReadLargeFile}}
> {{ITestS3APrefetchingInputStream.testReadLargeFileFully}}
> {{ITestS3APrefetchingInputStream.testReadLargeFileFullyLazySeek}}
> {{ITestS3ARequesterPays.testRequesterPaysOptionSuccess}}
> {{ITestAssumeRole.testReadOnlyOperations }}
> {{ITestPartialRenamesDeletes.testRenameParentPathNotWriteable}}
> {{ITestPartialRenamesDeletes.testRenameParentPathNotWriteable}}
> {{ITestS3GuardTool.testLandsatBucketRequireUnencrypted}}
>
> Most of these are because they're using landsat data which is not encrypted,
> so trying to read with a CSE will fail. These tests should be skipped if
> using CSE.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
