xinglin commented on PR #5764: URL: https://github.com/apache/hadoop/pull/5764#issuecomment-1603146650
Hi @goiri, Summary of changes to fix unit test failures. - Make two subclasses of NameNode as metric source as well, by adding a `@Metrics` annotation, since we have made NameNode a metric source. - Fixed `getCurrentBlockPoolID() `bug in a couple of unit tests. We set `NameNode.started ` flag to `false` in `NameNode.stop()` method. However, if we pass a `cluster` object to `getCurrentBlockPoolID`(), it will check to ensure the NameNode is started. Fixed it by passing a `null` to `getCurrentBlockPoolID()`, which is what existing code is doing as well. TestRollingUpgrade passed all tests on my laptop. Let's see how the build goes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
