mehakmeet commented on PR #5763: URL: https://github.com/apache/hadoop/pull/5763#issuecomment-1603647229
Had the same patch in my local repo 😄. Thanks for taking this up @ahmarsuhail. Yes, there was a gap in testing with Assume role + CSE enabled which led to this test being missed. Since there are quite a few toggleable features the testing coverage does get some blind spots. Not sure if there's already one, but a documented list of features that can cover the whole test suite could be helpful like CSE, Assume Roles, Access point ARN, SSE etc. In my testing of CSE + Assume role I believe the only tests failed for me were the Assume role one and `ITestPartialRenamesDeletes.java`, however the failure was due to some Access denied which could be due to a gap in my assume role policy maybe, was on my list to investigate that. I'll checkout your patch and run it through my configs once and let you know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
