zhangshuyan0 commented on code in PR #5776: URL: https://github.com/apache/hadoop/pull/5776#discussion_r1241388568
########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java: ########## @@ -977,7 +977,6 @@ public void testChooseReplicaToDelete() throws Exception { //Even if this node has the most space, because the storage[5] has //the lowest it should be chosen in case of block delete. - storages[4].setRemainingForTests(100 * 1024 * 1024); Review Comment: This modification requires a more detailed explanation. The above comment indicates that line 980 is intended to construct a node with the most remaining space, so I think it should not be deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org