[
https://issues.apache.org/jira/browse/HADOOP-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kihwal Lee updated HADOOP-8088:
-------------------------------
Attachment: hadoop-8088-branch-1.patch
For the branch-1 patch
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 13 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 6 new Findbugs
(version 1.3.9) warnings.
{noformat}
I manually ran findbugs again. There is no difference before/after the patch:
Both have the same 217 warnings.
> User-group mapping cache incorrectly does negative caching on transient
> failures
> --------------------------------------------------------------------------------
>
> Key: HADOOP-8088
> URL: https://issues.apache.org/jira/browse/HADOOP-8088
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 0.20.205.0, 0.24.0, 0.23.1, 1.0.0, 1.1.0
> Reporter: Kihwal Lee
> Fix For: 0.24.0, 1.1.0, 0.23.2
>
> Attachments: hadoop-8088-branch-1.patch, hadoop-8088-trunk.patch
>
>
> We've seen a case where some getGroups() calls fail when the ldap server or
> the network is having transient failures. Looking at the code, the
> shell-based and the JNI-based implementations swallow exceptions and return
> an empty or partial list. The caller, Groups#getGroups() adds this likely
> empty list into the mapping cache for the user. This will function as
> negative caching until the cache expires. I don't think we want negative
> caching here, but even if we do, it should be intelligent enough to
> distinguish transient failures from ENOENT. The log message in the jni-based
> impl also needs an improvement. It should print what exception it encountered
> instead of just saying one happened.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
