zhangshuyan0 commented on code in PR #5794:
URL: https://github.com/apache/hadoop/pull/5794#discussion_r1247516644
##########
hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md:
##########
@@ -304,6 +306,7 @@ Usage:
| `-idleiterations` \<iterations\> | Maximum number of idle iterations before
exit. This overwrites the default idleiterations(5). |
| `-runDuringUpgrade` | Whether to run the balancer during an ongoing HDFS
upgrade. This is usually not desired since it will not affect used space on
over-utilized machines. |
| `-asService` | Run Balancer as a long running service. |
+| `-sortTopNodes` | Whether to run the balancer during will sort nodes b
capacity usage percentage to prioritize top used nodes. |
Review Comment:
This sentence doesn't seem to make sense.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java:
##########
@@ -206,9 +206,9 @@ public class Balancer {
+ "on over-utilized machines."
+ "\n\t[-asService]\tRun as a long running service."
+ "\n\t[-sortTopNodes]"
- + "\n\t[-hotBlockTimeInterval]\tprefer to move cold blocks."
+ "\tSort datanodes based on the utilization so "
- + "that highly utilized datanodes get scheduled first.";
+ + "that highly utilized datanodes get scheduled first."
Review Comment:
Code style: align at the beginning of a line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
