virajjasani commented on PR #5754: URL: https://github.com/apache/hadoop/pull/5754#issuecomment-1614267547
> Looks good. Some changes in the test. What would really be good is to Test this in a multi-threaded test too, nothing major but creating an executor Service with 5 threads then trying to read and evict 3 blocks and asserting the correct IOStats and read values should be enough. This would test the locking as well. thanks for the review @mehakmeet updated test to perform seeks and reads in parallel using thread pool. so we have two follow-up sub-tasks to be created later: 1. refactor Entry class to its own independent class and create UT to test LRU cache head and tail pointers 2. add `blockEvictedFromFileCache()` metric does this sound good? i will re-run the whole test-suite against `us-west-2` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
