tomicooler commented on code in PR #5783:
URL: https://github.com/apache/hadoop/pull/5783#discussion_r1251071990
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbsoluteResourceCapacityCalculator.java:
##########
@@ -44,8 +44,14 @@ public double calculateMinimumResource(
double remainingResourceRatio =
resourceCalculationDriver.getRemainingRatioOfResource(
label, resourceName);
- return normalizedRatio * remainingResourceRatio *
context.getCurrentMinimumCapacityEntry(
+ double minimumCapacity = context.getCurrentMinimumCapacityEntry(
Review Comment:
Looks like it's no longer needed, I'll run 2x test with both legacy and the
new mode, without this change.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbsoluteResourceCapacityCalculator.java:
##########
@@ -59,7 +65,20 @@ public double calculateMaximumResource(
public void updateCapacitiesAfterCalculation(
ResourceCalculationDriver resourceCalculationDriver, CSQueue queue,
String label) {
CapacitySchedulerQueueCapacityHandler.setQueueCapacities(
-
resourceCalculationDriver.getUpdateContext().getUpdatedClusterResource(label),
queue, label);
+ resourceCalculationDriver.getUpdateContext()
+ .getUpdatedClusterResource(label), queue, label);
+
+ if (queue.getParent() != null) {
Review Comment:
Looks like it's no longer needed, I'll run 2x test with both legacy and the
new mode, without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
