xinglin commented on PR #5804: URL: https://github.com/apache/hadoop/pull/5804#issuecomment-1620842873
The two checkstyle warnings are because we normally do not add `private` for metric variables (other metrics don't have visibility modifier neither). ``` RpcDetailedMetrics.java:46: @Metric MutableRatesWithAggregation overallRpcProcessingRates;:39: Variable 'overallRpcProcessingRates' must be private and have accessor methods. [VisibilityModifier] RpcMetrics.java:133: MutableCounterLong rpcCallSuccesses;:22: Variable 'rpcCallSuccesses' must be private and have accessor methods. [VisibilityModifier] ``` @goiri, could you help merge this PR into branch-3.3 as well? thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
