[
https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740387#comment-17740387
]
ASF GitHub Bot commented on HADOOP-18781:
-----------------------------------------
mehakmeet commented on code in PR #5780:
URL: https://github.com/apache/hadoop/pull/5780#discussion_r1253884184
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java:
##########
@@ -493,6 +494,12 @@ public synchronized void close() throws IOException {
}
try {
+ // Check if Executor Service got shutdown before the writes could be
+ // completed.
+ if (hasActiveBlockDataToUpload() && executorService.isShutdown()) {
+ throw new IOException("Executor Service closed before writes could be"
Review Comment:
Okay. I intentionally left it to be IOE with no path, since that was being
added inside of `wrapException()` anyways.
Here's how it looked
```
exception: Failed with java.io.IOException while processing file/directory
:[/test/testAbfsThreadPool5ed597ff7617] in method:[Executor Service closed
before writes could be completed.]
```
Also, since in `wrapException()` we explicitly check if this is an instance
PathIOE, we simply throw it back, we may not require a boolean.
> ABFS Output stream thread pools getting shutdown during GC.
> -----------------------------------------------------------
>
> Key: HADOOP-18781
> URL: https://issues.apache.org/jira/browse/HADOOP-18781
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Reporter: Mehakmeet Singh
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: pull-request-available
>
> Applications using AzureBlobFileSystem to create the AbfsOutputStream can use
> the AbfsOutputStream for the purpose of writing, however, the OutputStream
> doesn't hold any reference to the fs instance that created it, which can make
> the FS instance eligible for GC, when this occurs, AzureblobFileSystem's
> `finalize()` method gets called which in turn closes the FS, and in turn call
> the close for AzureBlobFileSystemStore, which uses the same Threadpool that
> is used by the AbfsOutputStream. This leads to the closing of the thread pool
> while the writing is happening in the background and leads to hanging while
> writing.
>
> *Solution:*
> Pass a backreference of AzureBlobFileSystem into AzureBlobFileSystemStore and
> AbfsOutputStream as well.
>
> Same should be done for AbfsInputStream as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
