mccormickt12 commented on code in PR #5803:
URL: https://github.com/apache/hadoop/pull/5803#discussion_r1258991487
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##########
@@ -648,6 +645,7 @@ public synchronized void close() throws IOException {
}
}
failoverProxy.close();
+ nnProbingThreadPool.shutdown();
Review Comment:
so whats the expected behavior? We finish, then it'll idle for how many
seconds (blocking)?
also its not obvious to me that the main thread timing out or the GC calling
close is the thing that we will be blocked on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
