[
https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743625#comment-17743625
]
ASF GitHub Bot commented on HADOOP-18807:
-----------------------------------------
zhangshuyan0 commented on code in PR #5847:
URL: https://github.com/apache/hadoop/pull/5847#discussion_r1264884503
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -413,6 +413,11 @@ public T getTargetFileSystem() throws IOException {
}
return targetFileSystem;
}
+
+ T getTargetFileSystemForClose() throws IOException {
Review Comment:
Some target FileSystem may not have be initialized. `getTargetFileSystem`
initializes all target FileSystems (line1039 below). It's costly and
unnecessary when we just try to close them.
https://github.com/apache/hadoop/blob/c44823dadb73a3033f515329f70b2e3126fcb7be/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java#L1036-L1039
> Close child file systems in ViewFileSystem when cache is disabled.
> ------------------------------------------------------------------
>
> Key: HADOOP-18807
> URL: https://issues.apache.org/jira/browse/HADOOP-18807
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Shuyan Zhang
> Priority: Major
> Labels: pull-request-available
>
> When the cache is configured to disabled (namely,
> `fs.viewfs.enable.inner.cache=false` and `fs.*.impl.disable.cache=true`),
> even if `FileSystem.close()` is called, the client cannot truly close the
> child file systems in a ViewFileSystem. This caused our long-running clients
> to constantly produce resource leaks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
