ferdelyi commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266723998
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEvent.java:
##########
@@ -23,13 +23,23 @@
public class RMAppRunningOnNodeEvent extends RMAppEvent {
private final NodeId node;
+ private final boolean inAcquiredState;
Review Comment:
My impression is that in the current implementation, the inAcquiredState =
true is set when the container is transitioning into the ACQUIRED state, and in
this context, the flag meaning is that the container is in the ACQUIRED state.
E.g. RMContainerImpl:106 -> ALLOCATED to ACQUIRED triggers the
AcquiredTransition, which sets the flag to true.
If we trigger a transition event when get from the ACQUIRED state to the
RELEASED state, then yes I would agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
