steveloughran commented on PR #5767: URL: https://github.com/apache/hadoop/pull/5767#issuecomment-1643587230
I'm thinking this move is time to revisit my refactoring plans and actually split s3afs into two layers, filesystem and store, as abfs does. we'd have all those callback interfaces done in the store class, which would also contain the threadpool, transfer manager etc -and all those `inner*()` ops in s3a fs would move down with the audit context passed in as an explicit param. lets make sure this pr is ready for it by using an interface for callbacks to create s3 client, ideally even invoke the region call. that way we can hide these classes from the details of the SDK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
