symious commented on code in PR #5863:
URL: https://github.com/apache/hadoop/pull/5863#discussion_r1269247301
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/protocolPB/PBHelper.java:
##########
@@ -134,4 +136,14 @@ public static FileStatusProto convert(FileStatus stat)
throws IOException {
return bld.build();
}
+ public static ExceptionReconstructParamsProto getReconstructParams(Throwable
t) {
+ if (t instanceof ReconstructableException) {
Review Comment:
Updated, please have a look.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java:
##########
@@ -47,12 +50,23 @@ public RemoteException(String className, String msg) {
* @param erCode may be null
*/
public RemoteException(String className, String msg, RpcErrorCodeProto
erCode) {
+ this(className, msg, erCode, null);
+ }
+
+ /**
+ * @param className wrapped exception, may be null
Review Comment:
Updated.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java:
##########
@@ -47,12 +50,23 @@ public RemoteException(String className, String msg) {
* @param erCode may be null
*/
public RemoteException(String className, String msg, RpcErrorCodeProto
erCode) {
+ this(className, msg, erCode, null);
+ }
+
+ /**
+ * @param className wrapped exception, may be null
+ * @param msg may be null
+ * @param erCode may be null
+ */
+ public RemoteException(String className, String msg, RpcErrorCodeProto
erCode,
+ ExceptionReconstructParamsProto paramsProto) {
super(msg);
this.className = className;
if (erCode != null)
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
