[
https://issues.apache.org/jira/browse/HADOOP-18795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745022#comment-17745022
]
ASF GitHub Bot commented on HADOOP-18795:
-----------------------------------------
ahmarsuhail commented on code in PR #5821:
URL: https://github.com/apache/hadoop/pull/5821#discussion_r1269268310
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/S3ADelegationTokens.java:
##########
@@ -123,7 +123,12 @@ public class S3ADelegationTokens extends AbstractDTService
{
/**
* List of cred providers; unset until {@link #bindToDelegationToken(Token)}.
*/
- private Optional<AWSCredentialProviderList> credentialProviders
+ //private Optional<AWSCredentialProviderList> credentialProviders =
Optional.empty();
Review Comment:
this should be removed now?
> s3a DelegationToken plugin to expand return type of deploy/binding
> ------------------------------------------------------------------
>
> Key: HADOOP-18795
> URL: https://issues.apache.org/jira/browse/HADOOP-18795
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: pull-request-available
>
> Change the binding result of s3a DT services beyond just a credential list
> this will the extension point
> * return a new signer integrated with the fs
> * add something to help with the building the requests to delete objects
> during paged delete
> * gives us an option to add any more stuff
> this is incompatible, but the move to AWS v2 breaks DTs bindings anyway...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
