[
https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745028#comment-17745028
]
ASF GitHub Bot commented on HADOOP-18752:
-----------------------------------------
steveloughran commented on code in PR #5859:
URL: https://github.com/apache/hadoop/pull/5859#discussion_r1269279118
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md:
##########
@@ -339,16 +339,19 @@ Hadoop supports [different policies for directory marker
retention](directory_ma
-essentially the classic "delete" and the higher-performance "keep" options;
"authoritative"
is just "keep" restricted to a part of the bucket.
-Example: test with `markers=delete`
+
+Example: test with `markers=keep`
```
-mvn verify -Dparallel-tests -DtestsThreadCount=4 -Dmarkers=delete
+mvn verify -Dparallel-tests -DtestsThreadCount=4 -Dmarkers=keep
```
-Example: test with `markers=keep`
+This is the default and does not need to be explicitly set.
Review Comment:
oops; wrong
> Change fs.s3a.directory.marker.retention to "keep"
> --------------------------------------------------
>
> Key: HADOOP-18752
> URL: https://issues.apache.org/jira/browse/HADOOP-18752
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.5
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Change the default value of "fs.s3a.directory.marker.retention" to keep;
> update docs to match.
> maybe include with HADOOP-17802 so we don't blow up with fewer markers being
> created.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
