steveloughran commented on code in PR #5851:
URL: https://github.com/apache/hadoop/pull/5851#discussion_r1269298649
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java:
##########
@@ -97,13 +95,11 @@ public void teardown() throws Exception {
largeFileFS = null;
}
- private void openFS(String fileName) throws Exception {
- Configuration conf = getConfiguration();
+ private void createLargeFile() throws Exception {
byte[] data = ContractTestUtils.dataset(S_1K * 72, 'x', 26);
- largeFile = path(fileName);
+ largeFile = methodPath();
Review Comment:
this should be made a local variable; class field removed as well as teardown
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingLruEviction.java:
##########
@@ -106,19 +105,17 @@ public void teardown() throws Exception {
smallFileFS = null;
}
- private void openFS() throws Exception {
- Configuration conf = getConfiguration();
+ private void createSmallFile() throws Exception {
byte[] data = ContractTestUtils.dataset(SMALL_FILE_SIZE, 'x', 26);
- smallFile = path("iTestS3APrefetchingLruEviction");
+ smallFile = methodPath();
Review Comment:
this should be made a local variable; class field removed as well as teardown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
