Hexiaoqiao commented on code in PR #5877:
URL: https://github.com/apache/hadoop/pull/5877#discussion_r1271707754
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -3891,6 +3891,8 @@ private void processMisReplicatesAsync() throws
InterruptedException {
// initialisation, then progress might be different.
reconstructionQueuesInitProgress = Math.min((double) totalProcessed
/ totalBlocks, 1.0);
+ LOG.info("Reconstruction queues initialisation progress: {}, total
number of blocks " +
Review Comment:
I have always believed that it is not a good practice to involve some
IOs(include print log) inner Read/Write Lock, here in global write lock. Please
check if it could move out.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/FSNamesystemMBean.java:
##########
@@ -261,4 +261,11 @@ public interface FSNamesystemMBean {
* @return The number of paths to be processed by sps.
*/
int getPendingSPSPaths();
+
+ /**
+ * Get the progress of the reconstruction queues initialisation
+ *
+ * @return Returns values between 0 and 1 for the progress.
+ */
+ double getReconstructionQueuesInitProgress();
Review Comment:
Add unit test should be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
