tomicooler commented on code in PR #5871:
URL: https://github.com/apache/hadoop/pull/5871#discussion_r1271264069
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java:
##########
@@ -463,12 +463,14 @@ protected void setDynamicQueueProperties() {
queueContext.getQueueManager().getConfiguredNodeLabelsForAllQueues()
.setLabelsByQueue(getQueuePath(), new
HashSet<>(parentNodeLabels));
}
+ Map<String, QueueCapacityVector> templateConfiguredResourceVector =
queueContext.getConfiguration()
+ .parseConfiguredResourceVector(queuePath.getFullPath(),
parentNodeLabels);
+
Review Comment:
I'm missing the part where the configuredCapacityVector (and
configuredMaxCapacityVector) is updated with this information. Are those
already have the correctly parsed capacity vectors at the setupQueueConfigs
phase, if so there is no need for parsing them again.
Anyway the field member configurecCapacityVector should have the correct
value set somewhere. Some e2e test with JSON asserts should verify it later.
Maybe this new UT could also assert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
