sadanand48 commented on PR #5885:
URL: https://github.com/apache/hadoop/pull/5885#issuecomment-1653039629

   Thanks @ayushtkn for taking a look.
   
   1. If the config (`traverseDirectories`) is set to false in case of HDFS, it 
will cause `DuplicateFileException` and fail the distcp operation. Hence the 
default is set to true. 
   2. I agree , this is a good point and can solve the below problems you 
stated wrt to the same config object being used by both HDFS and Ozone in an 
application like Hive replication etc. I will raise a follow up patch/jira to 
solve this case and the config to be deduced from the fs scheme. 
   3. For `getTraverseExcludeList` : redundant copy case comes only when we 
recursively traverse and add paths not present in the diff. Here we are adding 
all paths from diff itself, so it wouldn't have any redundant path. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to