[
https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229662#comment-13229662
]
Eli Collins commented on HADOOP-8159:
-------------------------------------
- Why report the entire topology as json in the message? This string is likely
to be very big on a real cluster right? Probably better to make that accessible
via the NN web UI (can punt to a separate change)
- An error message like "Invalid network location for Datanode: Datanode given
rack-level network location can not be at rack-level" is probably more clear
than referencing class names not visible to the user
- In testCreateInvalidTopology in the catch clause let's assert the contents of
e.getMessage, ie that it indicates that h3 is the bad node
- How about adding test cases for other invalid toplogies (eg 3 or 4 level deep
topology, null, empty string)
- Nit: bracket for catch InvalidTopologyException goes on the same line
> NetworkTopology: getLeaf should check for invalid topologies
> ------------------------------------------------------------
>
> Key: HADOOP-8159
> URL: https://issues.apache.org/jira/browse/HADOOP-8159
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 1.0.0
>
> Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch
>
>
> Currently, in NetworkTopology, getLeaf doesn't do too much validation on the
> InnerNode object itself. This results in us getting ClassCastException
> sometimes when the network topology is invalid. We should have a less
> confusing exception message for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
