[
https://issues.apache.org/jira/browse/HADOOP-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229774#comment-13229774
]
Eli Collins commented on HADOOP-4885:
-------------------------------------
bq. I didn't get your seco- nd question: my patch uses addStorageDir too.
What I meant was the trunk patch does the following, which is much shorter:
{code}
sd.clearDirectory();
addStorageDir(sd);
{code}
and leverages the fact that checkpoint populates the directory. Why not use the
same approach here?
- I'd test with a real NFS mount and disconnect/reconnect the network. I found
some bugs that way when backporting this a while back. Also discovered
HDFS-2701, HDFS-2702, HDFS-2703 via testing with a real build instead of the
unit tests.
- Nit: s/"may should be mounted"/"may be a network mount"/
> Try to restore failed replicas of Name Node storage (at checkpoint time)
> ------------------------------------------------------------------------
>
> Key: HADOOP-4885
> URL: https://issues.apache.org/jira/browse/HADOOP-4885
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.21.0
>
> Attachments: HADOOP-4885-1.patch, HADOOP-4885-3.patch,
> HADOOP-4885-3.patch, HADOOP-4885.branch-1.patch,
> HADOOP-4885.branch-1.patch.2, HADOOP-4885.branch-1.patch.3,
> HADOOP-4885.patch, HADOOP-4885.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
