ahmarsuhail commented on code in PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#discussion_r1281774011
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -562,15 +563,65 @@ public static long dateToLong(final Date date) {
* @return instance of the specified class
* @throws IOException on any problem
*/
- @SuppressWarnings("unchecked")
- public static <InstanceT> InstanceT getInstanceFromReflection(Class<?>
instanceClass,
- Configuration conf, @Nullable URI uri, Class<?> interfaceImplemented,
String methodName,
+ public static <InstanceT> InstanceT getInstanceFromReflection(
Review Comment:
we can just get rid of this method? the only place it's used I think is
SignerFactory.createSigner(), which can also be updated to pass in
`signerClass.getName()` and use the new method
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md:
##########
@@ -65,7 +201,7 @@ The s3 client is an instance of `S3Client` in V2 rather than
`AmazonS3`.
For this reason, the `S3ClientFactory` will be deprecated and replaced by one
that creates a V2
`S3Client`.
-The `getAmazonS3ClientForTesting()` method will also be updated to return the
`S3Client`.
+The `getAmazonS3ClientForTesting()` method has been updated to return the
`S3Client`.
### Signers
Review Comment:
do you think it's worth mentioning there's no sigV2 right now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
