[
https://issues.apache.org/jira/browse/HADOOP-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750596#comment-17750596
]
ASF GitHub Bot commented on HADOOP-18767:
-----------------------------------------
anardana opened a new pull request, #5916:
URL: https://github.com/apache/hadoop/pull/5916
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
WeakReferenceMap.create(K key) logs once at warning level if a reference to
a key was lost during creation.
It logs key incorrectly. Fixed the logger so that key is also emitted by the
log line.
### For code changes:
- [ X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> WeakReferenceMap creation warning log doesn't format correctly
> --------------------------------------------------------------
>
> Key: HADOOP-18767
> URL: https://issues.apache.org/jira/browse/HADOOP-18767
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.3.5
> Reporter: Steve Loughran
> Priority: Trivial
>
> {{WeakReferenceMap.create(K key)}} logs once at warning level if a reference
> to a key was lost during creation.
> {code}
> referenceLostDuringCreation.warn("reference to %s lost during creation", key);
> {code}
> but it uses %s as the insertion point for the key, when it should be {}.
> this means the log, if it ever surfaces, won't include the key.
> i don't think this is a very important issue, but it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
