[
https://issues.apache.org/jira/browse/HADOOP-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751556#comment-17751556
]
ASF GitHub Bot commented on HADOOP-18840:
-----------------------------------------
slfan1989 commented on code in PR #5926:
URL: https://github.com/apache/hadoop/pull/5926#discussion_r1285607605
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##########
@@ -257,6 +264,19 @@ public void incrReceivedBytes(int count) {
receivedBytes.incr(count);
}
+ /**
+ * Add an RPC enqueue time sample
+ * @param enQTime the queue time
Review Comment:
Comments should describe in more detail.
> Add enQueue time to RpcMetrics
> ------------------------------
>
> Key: HADOOP-18840
> URL: https://issues.apache.org/jira/browse/HADOOP-18840
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
> Reporter: Liangjun He
> Assignee: Liangjun He
> Priority: Minor
> Labels: pull-request-available
>
> Sometimes, the request time observed by the client is much longer than the
> queue + process time on the RPC server. Perhaps the RPC request 'waiting
> enQueue' took too long on the RPC server, so we should add enQueue time to
> RpcMetrics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
