simbadzina commented on PR #5951: URL: https://github.com/apache/hadoop/pull/5951#issuecomment-1681496761
> @tasanuma Thank your for the review and approval! @simbadzina Thanks for your comments. I cherry-picked your unit test and it worked well in my local environment. Thanks! > > Below is the test result in my local environment: with the fix: > > ``` > mvn test -Dtest=TestIPC.java > [INFO] ------------------------------------------------------- > [INFO] T E S T S > [INFO] ------------------------------------------------------- > [INFO] Running org.apache.hadoop.ipc.TestIPC > [WARNING] Tests run: 46, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 112.083 s - in org.apache.hadoop.ipc.TestIPC > [INFO] > [INFO] Results: > [INFO] > [WARNING] Tests run: 46, Failures: 0, Errors: 0, Skipped: 1 > ``` > > without the fix: failed as expected > > ``` > mvn test -Dtest=TestIPC.java > [INFO] Running org.apache.hadoop.ipc.TestIPC > [ERROR] Tests run: 46, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 113.739 s <<< FAILURE! - in org.apache.hadoop.ipc.TestIPC > [ERROR] testReceiveStateBeforeCallerNotification(org.apache.hadoop.ipc.TestIPC) Time elapsed: 0.181 s <<< FAILURE! > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:87) > at org.junit.Assert.assertTrue(Assert.java:42) > at org.junit.Assert.assertTrue(Assert.java:53) > at org.apache.hadoop.ipc.TestIPC.testReceiveStateBeforeCallerNotification(TestIPC.java:1365) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) > at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.lang.Thread.run(Thread.java:829) > ``` For sure. Thanks for finding and fixing this bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
