steveloughran commented on code in PR #5960:
URL: https://github.com/apache/hadoop/pull/5960#discussion_r1298431726


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java:
##########
@@ -98,17 +99,25 @@ public S3AsyncClient createS3AsyncClient(
 
     Configuration conf = getConf();
     String bucket = uri.getHost();
+
     NettyNioAsyncHttpClient.Builder httpClientBuilder = AWSClientConfig

Review Comment:
   is this going to build properly with unshaded artifacts? we've caused 
problems in the path (#2599) because of refs to .shaded classes.. the netty and 
client stuff are public/stable unshaded classes, correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to