[ 
https://issues.apache.org/jira/browse/HADOOP-18853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755965#comment-17755965
 ] 

ASF GitHub Bot commented on HADOOP-18853:
-----------------------------------------

steveloughran commented on code in PR #5960:
URL: https://github.com/apache/hadoop/pull/5960#discussion_r1298431726


##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/DefaultS3ClientFactory.java:
##########
@@ -98,17 +99,25 @@ public S3AsyncClient createS3AsyncClient(
 
     Configuration conf = getConf();
     String bucket = uri.getHost();
+
     NettyNioAsyncHttpClient.Builder httpClientBuilder = AWSClientConfig

Review Comment:
   is this going to build properly with unshaded artifacts? we've caused 
problems in the path (#2599) because of refs to .shaded classes.. the netty and 
client stuff are public/stable unshaded classes, correct?





> AWS SDK V2 - Integrate new transfer manager
> -------------------------------------------
>
>                 Key: HADOOP-18853
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18853
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Ahmar Suhail
>            Priority: Major
>              Labels: pull-request-available
>
> With 2.20.121, the TM has MPU functionality. Upgrading to to this version 
> will also solve the issue with needing to include the CRT dependency. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to