[ 
https://issues.apache.org/jira/browse/HADOOP-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757963#comment-17757963
 ] 

ASF GitHub Bot commented on HADOOP-18328:
-----------------------------------------

steveloughran commented on code in PR #5976:
URL: https://github.com/apache/hadoop/pull/5976#discussion_r1302840801


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
+
+Accessing data through an access point, is done by using its ARN, as opposed 
to just the bucket name. The only supported storage class on Outposts is 
**OUTPOSTS**, and by default objects are encrypted with (SSE-S3), for more 
information, see [Data encryption in S3 on 
Outposts](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-outposts-data-encryption.html).
 You can set the Access Point ARN property using the following per bucket 
configuration property:
+
+```
+<property>
+<name>fs.s3a.bucket.sample-outpost-bucket.accesspoint.arn</name>
+<value>arn:aws:s3-outposts:region:account-id:outpost/outpost-id/accesspoint/accesspoint-name</value>
+<description>Configure S3a traffic to us this S3 on Outposts Access Point 
ARN</description>

Review Comment:
   nit: use



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).

Review Comment:
   can you cut the explicit version number; complicates backporting and 
cherrypicking



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
+
+Accessing data through an access point, is done by using its ARN, as opposed 
to just the bucket name. The only supported storage class on Outposts is 
**OUTPOSTS**, and by default objects are encrypted with (SSE-S3), for more 
information, see [Data encryption in S3 on 
Outposts](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-outposts-data-encryption.html).
 You can set the Access Point ARN property using the following per bucket 
configuration property:
+
+```
+<property>
+<name>fs.s3a.bucket.sample-outpost-bucket.accesspoint.arn</name>
+<value>arn:aws:s3-outposts:region:account-id:outpost/outpost-id/accesspoint/accesspoint-name</value>
+<description>Configure S3a traffic to us this S3 on Outposts Access Point 
ARN</description>
+</property>
+```
+
+This configures access to the sample-outpost-bucket for S3A, to go through the 
new Access Point ARN. So, for example s3a://sample-outpost-bucket/key will now 
use your configured ARN when getting data from S3 on Outpost instead of your 
bucket.

Review Comment:
   1. quote `sample-outpost-bucket`  with backticks, 
   2. drop the comma in the first sentence
   3. quote the s3a url with `backticks`



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
+
+Accessing data through an access point, is done by using its ARN, as opposed 
to just the bucket name. The only supported storage class on Outposts is 
**OUTPOSTS**, and by default objects are encrypted with (SSE-S3), for more 
information, see [Data encryption in S3 on 
Outposts](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-outposts-data-encryption.html).
 You can set the Access Point ARN property using the following per bucket 
configuration property:
+
+```

Review Comment:
   add xml to trigger any xml-specific highighting



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
+
+Accessing data through an access point, is done by using its ARN, as opposed 
to just the bucket name. The only supported storage class on Outposts is 
**OUTPOSTS**, and by default objects are encrypted with (SSE-S3), for more 
information, see [Data encryption in S3 on 
Outposts](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-outposts-data-encryption.html).
 You can set the Access Point ARN property using the following per bucket 
configuration property:
+
+```
+<property>
+<name>fs.s3a.bucket.sample-outpost-bucket.accesspoint.arn</name>

Review Comment:
   add two space indents for the inner elements



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
+
+Accessing data through an access point, is done by using its ARN, as opposed 
to just the bucket name. The only supported storage class on Outposts is 
**OUTPOSTS**, and by default objects are encrypted with (SSE-S3), for more 
information, see [Data encryption in S3 on 
Outposts](https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-outposts-data-encryption.html).
 You can set the Access Point ARN property using the following per bucket 
configuration property:

Review Comment:
   cut first ,



##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1709,6 +1709,23 @@ the storage class you want.
 Please note that S3A does not support reading from archive storage classes at 
the moment.
 `AccessDeniedException` with InvalidObjectState will be thrown if you're 
trying to do so.
 
+## <a name="upload"></a>Configuring S3A for S3 on Outposts
+
+S3A now supports S3 on Outposts, and is available in Hadoop v.3.3.7 and 
beyond.  AWS Outposts is a fully managed service that offers the same AWS 
infrastructure, AWS services, APIs, and tools to virtually any data center, 
co-location space, or on-premises. For more information, see the [AWS Outposts 
User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).
 Amazon S3 on Outposts delivers object storage to your on-premises AWS Outposts 
rack environment.  S3 on Outposts provides a new storage class, OUTPOSTS,  and 
you communicate with your Outposts bucket by using an access point and endpoint 
connection over a virtual private cloud (VPC). For more information see the [S3 
on Outposts User 
Guide](https://docs.aws.amazon.com/AmazonS3/latest/userguide/S3onOutposts.html).

Review Comment:
   I'd prefer if this was broken down to separate lines, at least after every 
sentence. makes it easier to review changes





> S3A supports S3 on Outposts
> ---------------------------
>
>                 Key: HADOOP-18328
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18328
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>            Reporter: Sotetsu Suzugamine
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, the endpoint for using S3 accesspoint is set as 
> "s3-accesspoint.%s.amazonaws.com" as follows.
> [https://github.com/apache/hadoop/blob/3ec4b932c179d9ec6c4e465f25e35b3d7eded08b/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/ArnResource.java#L29]
> However, "s3-outposts.%s.amazonaws.com" is the preferred endpoint when 
> accessing S3 on Outposts bucket by accesspoint.
> This ticket improves them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to