mehakmeet commented on code in PR #5948:
URL: https://github.com/apache/hadoop/pull/5948#discussion_r1302993019
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Invoker.java:
##########
@@ -471,7 +471,8 @@ public <T> T retryUntranslated(
}
// you only get here if the operation didn't complete
// normally, hence caught != null
-
+ LOG.debug("{} ; {}, ", text, caught.toString());
+ LOG.trace("{}", caught);
Review Comment:
doubt: Is there some string we intended to add for tracing before the
Exception stack trace? Else we can remove the placeholder "{}".
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -511,6 +513,34 @@ public void testConfOptionPropagationToFS() throws
Exception {
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test(timeout = 10_000L)
+ public void testConnectTtlPropagation() throws Exception {
+ Configuration config = new Configuration();
Review Comment:
We should unset the property here in case someone has already set this to
some value in their auth-keys.xml so that the default value test passes even if
some other value is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
