[
https://issues.apache.org/jira/browse/HADOOP-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758060#comment-17758060
]
ASF GitHub Bot commented on HADOOP-18845:
-----------------------------------------
mehakmeet commented on code in PR #5948:
URL: https://github.com/apache/hadoop/pull/5948#discussion_r1302993019
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Invoker.java:
##########
@@ -471,7 +471,8 @@ public <T> T retryUntranslated(
}
// you only get here if the operation didn't complete
// normally, hence caught != null
-
+ LOG.debug("{} ; {}, ", text, caught.toString());
+ LOG.trace("{}", caught);
Review Comment:
doubt: Is there some string we intended to add for tracing before the
Exception stack trace? Else we can remove the placeholder "{}".
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java:
##########
@@ -511,6 +513,34 @@ public void testConfOptionPropagationToFS() throws
Exception {
assertOptionEquals(updated, "fs.s3a.propagation", "propagated");
}
+ @Test(timeout = 10_000L)
+ public void testConnectTtlPropagation() throws Exception {
+ Configuration config = new Configuration();
Review Comment:
We should unset the property here in case someone has already set this to
some value in their auth-keys.xml so that the default value test passes even if
some other value is set.
> Add ability to configure ConnectionTTL of http connections while creating S3
> Client.
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-18845
> URL: https://issues.apache.org/jira/browse/HADOOP-18845
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.6
> Reporter: Mukund Thakur
> Assignee: Mukund Thakur
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.9
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
