[ 
https://issues.apache.org/jira/browse/HADOOP-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758453#comment-17758453
 ] 

ASF GitHub Bot commented on HADOOP-18860:
-----------------------------------------

steveloughran commented on code in PR #5977:
URL: https://github.com/apache/hadoop/pull/5977#discussion_r1304033879


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml:
##########
@@ -177,11 +177,6 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
       <artifactId>junit-jupiter-params</artifactId>
       <scope>test</scope>
     </dependency>
-      <dependency>

Review Comment:
   sorry, i meant "align the elements with the ones above"
   
   now, is this going to be needed or is it coming down from the other 
dependencies anyway (which I would expect). 
   
   we will find out from the result of the build; if all compiles then mockito 
core is pulled in by mockito.
   
   we've been burned a few times by people (myself included) not realising that 
when a -test jar is pulled in by another module, h of the test jars 
dependencies are transitively picked up. this has made rollout of assertJ 
harder than we'd like. Let's see what happens here





> Upgrade mockito to 4.11.0
> -------------------------
>
>                 Key: HADOOP-18860
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18860
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.3.6
>            Reporter: Anmol Asrani
>            Assignee: Anmol Asrani
>            Priority: Major
>              Labels: pull-request-available
>
> Upgrading mockito in hadoop-project



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to