steveloughran commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1694332645
> Do you want to keep providing scope optional or should we wrap this up under a profile? 1. the scope in this PR doesn't actually change protobuf 2.5 being exported 2. i had a goal of a followup pr which did that, something isolated so easy to revert 3. but yes, a protobuf-2.5.scope variable would let people switch from provided to compile on the command line. now, if we make it a switch, should i do it in this pr or that followup I was thinking about -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
