apurtell commented on code in PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#discussion_r1307788014
##########
hadoop-project/pom.xml:
##########
@@ -85,8 +85,14 @@
<!-- com.google.re2j version -->
<re2j.version>1.1</re2j.version>
- <!--Protobuf version for backward compatibility-->
+ <!-- Protobuf version for backward compatibility -->
+ <!-- This is used in hadoop-common for compilation only -->
<protobuf.version>2.5.0</protobuf.version>
+ <!-- Protobuf scope in hadoop common -->
+ <!-- set to "provided" and protobuf2 will no longer be exported as a
dependency -->
+ <common.protobuf2.scope>compile</common.protobuf2.scope>
+ <!-- Protobuf scope in other modules which explicitly import the libarary
-->
+
<transient.protobuf2.scope>${common.protobuf2.scope}</transient.protobuf2.scope>
Review Comment:
+1
Same question.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/protocolPB/RefreshAuthorizationPolicyProtocolClientSideTranslatorPB.java:
##########
@@ -21,17 +21,17 @@
import java.io.Closeable;
import java.io.IOException;
-import org.apache.hadoop.ipc.ProtobufHelper;
import org.apache.hadoop.ipc.ProtocolMetaInterface;
import org.apache.hadoop.ipc.RPC;
import org.apache.hadoop.ipc.RpcClientUtil;
import org.apache.hadoop.security.authorize.RefreshAuthorizationPolicyProtocol;
import
org.apache.hadoop.security.proto.RefreshAuthorizationPolicyProtocolProtos.RefreshServiceAclRequestProto;
-import
org.apache.hadoop.security.protocolPB.RefreshAuthorizationPolicyProtocolPB;
import org.apache.hadoop.thirdparty.protobuf.RpcController;
import org.apache.hadoop.thirdparty.protobuf.ServiceException;
+import static
org.apache.hadoop.ipc.internal.ShadedProtobufHelper.getRemoteException;
Review Comment:
A minor nit. There is an inconsistency where the other helper methods in
`ShadedProtobufHelper` are invoked without static import, but for some reason
`getRemoteException()` is an exception. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
