steveloughran commented on code in PR #5995:
URL: https://github.com/apache/hadoop/pull/5995#discussion_r1309005801
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java:
##########
@@ -224,9 +232,11 @@ protected Map<Class<? extends Exception>, RetryPolicy>
createExceptionMap() {
// server didn't respond.
policyMap.put(AWSNoResponseException.class, retryIdempotentCalls);
+ // translated AWS exceptions are retried if retryable() is true.
+ policyMap.put(AWSClientIOException.class, retryAwsClientExceptions);
+ policyMap.put(AWSServiceIOException.class, retryAwsClientExceptions);
Review Comment:
that's why I left this out. the thing is "retryable()" is meant to indicate
when things can't be retried, and we've been getting complaints about useless
retrying. but I've left it out of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
