slfan1989 commented on code in PR #5967:
URL: https://github.com/apache/hadoop/pull/5967#discussion_r1309504955
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java:
##########
@@ -120,7 +120,7 @@ public void setUp() {
// Initialize facade & stateSore
stateStore = new MemoryFederationStateStore();
stateStore.init(this.getConf());
- facade = FederationStateStoreFacade.getInstance();
+ facade = FederationStateStoreFacade.getInstance(this.getConf());
Review Comment:
I will read the code carefully to ensure the uniformity of usage. If there
is `configuration` in the usage class involved, we will use
`FederationStateStoreFacade.getInstance(this.getConf())`, if there is no
`configuration` in the usage class involved, we will use Will use
`FederationStateStoreFacade.getInstance()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
