slfan1989 commented on code in PR #5992:
URL: https://github.com/apache/hadoop/pull/5992#discussion_r1309521869
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java:
##########
@@ -877,6 +878,40 @@ public static Map<String, String>
getErasureCodeCodecs(Map<?, ?> json) {
return map;
}
+ public static Collection<FileStatus> getTrashRoots(Map<?, ?> json) {
+ List<?> objs = (List<?>) json.get("Paths");
+ if (objs != null) {
+ FileStatus[] trashRoots = new FileStatus[objs.size()];
+ for (int i = 0; i < objs.size(); i++) {
+ Map<?, ?> m = (Map<?, ?>) objs.get(i);
+ trashRoots[i] = toFileStatus(m);
+ }
+ return Arrays.asList(trashRoots);
+ }
+ return new ArrayList<FileStatus>(0);
+ }
+
+ public static FileStatus toFileStatus(Map<?, ?> json) {
+ Path path = new Path(getString(json, "path", ""));
+ long length = getLong(json, "length", 0);
+ boolean isdir = getBoolean(json, "isdir", false);
Review Comment:
Can "isdir" be a constant？
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java:
##########
@@ -877,6 +878,40 @@ public static Map<String, String>
getErasureCodeCodecs(Map<?, ?> json) {
return map;
}
+ public static Collection<FileStatus> getTrashRoots(Map<?, ?> json) {
+ List<?> objs = (List<?>) json.get("Paths");
+ if (objs != null) {
+ FileStatus[] trashRoots = new FileStatus[objs.size()];
+ for (int i = 0; i < objs.size(); i++) {
+ Map<?, ?> m = (Map<?, ?>) objs.get(i);
+ trashRoots[i] = toFileStatus(m);
+ }
+ return Arrays.asList(trashRoots);
+ }
+ return new ArrayList<FileStatus>(0);
+ }
+
+ public static FileStatus toFileStatus(Map<?, ?> json) {
+ Path path = new Path(getString(json, "path", ""));
+ long length = getLong(json, "length", 0);
+ boolean isdir = getBoolean(json, "isdir", false);
Review Comment:
Can "isdir" be a constant？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
