slfan1989 commented on code in PR #5975:
URL: https://github.com/apache/hadoop/pull/5975#discussion_r1311543472
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:
##########
@@ -1434,6 +1449,17 @@ private void mergeAllocateResponses(AllocateResponse
mergedResponse) {
}
}
}
+ // When re-register RM, client may not cache the NMToken from register
response.
+ // Here we pass these NMToken in allocate stage.
+ if (nmTokenMapFromRegisterSecondaryCluster.size() > 0) {
+ List<NMToken> duplicateNmToken = new
ArrayList(nmTokenMapFromRegisterSecondaryCluster);
Review Comment:
If nmTokenMapFromRegisterSecondaryCluster is already a set, why is
deduplication necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
