shameersss1 commented on code in PR #6006:
URL: https://github.com/apache/hadoop/pull/6006#discussion_r1311786504
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/impl/CommitUtilsWithMR.java:
##########
@@ -49,10 +49,11 @@ private CommitUtilsWithMR() {
/**
* Get the location of magic job attempts.
* @param out the base output directory.
+ * @param jobId unique Job ID.
* @return the location of magic job attempts.
*/
- public static Path getMagicJobAttemptsPath(Path out) {
- return new Path(out, MAGIC);
+ public static Path getMagicJobAttemptsPath(Path out, String jobId) {
+ return new Path(out, MAGIC + "_" + jobId);
Review Comment:
Ack. It makes sense!
btw formatJobDir() cannot be removed yet, Since public static String
formatAppAttemptDir still uses it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
