steveloughran commented on code in PR #6004:
URL: https://github.com/apache/hadoop/pull/6004#discussion_r1312864352
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java:
##########
@@ -76,16 +78,17 @@ public void testAbfsRestOperationExceptionFormat() throws
IOException {
String[] errorFields = errorMessage.split(",");
Assertions.assertThat(errorFields)
.describedAs("fields in exception of %s", ex)
- .hasSize(6);
+ .hasSize(7);
// Check status message, status code, HTTP Request Type and URL.
Assert.assertEquals("Operation failed: \"The specified path does not
exist.\"", errorFields[0].trim());
Assert.assertEquals("404", errorFields[1].trim());
Assert.assertEquals("GET", errorFields[2].trim());
Assert.assertTrue(errorFields[3].trim().startsWith("http"));
+ Assert.assertTrue(errorFields[4].trim().startsWith("rId:"));
Review Comment:
use assertj with a .startsWith() assertion.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java:
##########
@@ -60,12 +60,14 @@ public void testAbfsRestOperationExceptionFormat() throws
IOException {
String errorMessage = ex.getLocalizedMessage();
String[] errorFields = errorMessage.split(",");
- Assert.assertEquals(4, errorFields.length);
+ // Expected Fields are: Message, StatusCode, Method, URL, ActivityId(rId)
+ Assert.assertEquals(5, errorFields.length);
// Check status message, status code, HTTP Request Type and URL.
Assert.assertEquals("Operation failed: \"The specified path does not
exist.\"", errorFields[0].trim());
Assert.assertEquals("404", errorFields[1].trim());
Assert.assertEquals("HEAD", errorFields[2].trim());
Assert.assertTrue(errorFields[3].trim().startsWith("http"));
+ Assert.assertTrue(errorFields[4].trim().startsWith("rId:"));
Review Comment:
use assertj with a .startsWith() assertion.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java:
##########
@@ -76,16 +78,17 @@ public void testAbfsRestOperationExceptionFormat() throws
IOException {
String[] errorFields = errorMessage.split(",");
Assertions.assertThat(errorFields)
.describedAs("fields in exception of %s", ex)
- .hasSize(6);
+ .hasSize(7);
// Check status message, status code, HTTP Request Type and URL.
Assert.assertEquals("Operation failed: \"The specified path does not
exist.\"", errorFields[0].trim());
Assert.assertEquals("404", errorFields[1].trim());
Assert.assertEquals("GET", errorFields[2].trim());
Assert.assertTrue(errorFields[3].trim().startsWith("http"));
+ Assert.assertTrue(errorFields[4].trim().startsWith("rId:"));
// Check storage error code and storage error message.
- Assert.assertEquals("PathNotFound", errorFields[4].trim());
- Assert.assertTrue(errorFields[5].contains("RequestId")
- && errorFields[5].contains("Time"));
+ Assert.assertEquals("PathNotFound", errorFields[5].trim());
+ Assert.assertTrue(errorFields[6].contains("RequestId")
Review Comment:
use assertj with a .contains() assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
