goiri commented on code in PR #6013:
URL: https://github.com/apache/hadoop/pull/6013#discussion_r1313365757


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java:
##########
@@ -215,6 +216,39 @@ public void testSimpleRead() throws Exception {
     assertSentTo(0);
   }
 
+  @Test
+  public void testConfigStartup() throws Exception {
+    int numNameNodes = dfsCluster.getNumNameNodes();
+
+    // Transition all current observers to standby
+    for (int i = 0; i < numNameNodes; i++) {
+        if (dfsCluster.getNameNode(i).isObserverState()) {
+            dfsCluster.transitionToStandby(i);
+        }
+    }
+
+    // Add a new namenode with the observer startup option
+    conf.setBoolean(DFS_NAMENODE_OBSERVER_ENABLED_KEY, true);

Review Comment:
   Can we add a test with this to false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to