dannytbecker commented on code in PR #6013:
URL: https://github.com/apache/hadoop/pull/6013#discussion_r1317447791
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -1161,11 +1163,17 @@ private void stopAtException(Exception e){
}
}
- protected HAState createHAState(StartupOption startOpt) {
+ protected HAState createHAState(Configuration conf) {
+ StartupOption startOpt = getStartupOption(conf);
if (!haEnabled || startOpt == StartupOption.UPGRADE
|| startOpt == StartupOption.UPGRADEONLY) {
Review Comment:
Here is the document explaining the behavior and how it interacts with an HA
cluster.
https://hadoop.apache.org/docs/r3.3.4/hadoop-project-dist/hadoop-hdfs/HDFSHighAvailabilityWithQJM.html#HDFS_Upgrade.2FFinalization.2FRollback_with_HA_Enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
